Skip to main content

Where does the time go? In "link_to"

For a table with 9400 records:

The following code, all Ruby On Rails-ed up, takes 8.15s
<table>
<tr>
<% for column in Journalabbr.content_columns %>
<th align="left"><%= column.human_name %></th>
<% end %>
</tr>

<% for journalabbr in @journalabbrs %>
<tr>
<% for column in Journalabbr.content_columns %>
<td><%=h journalabbr.send(column.name) %></td>
<% end %>
<td><%= link_to 'Show', :action => 'show', :id => journalabbr %></td>
<td><%= link_to 'Edit', :action => 'edit', :id => journalabbr %></td>
<td><%= link_to 'Destroy', { :action => 'destroy', :id => journalabbr }, :confirm => 'Are you sure?' %></td>
</tr>
<% end %>
</table>

By removing content_columns and send_columns and explicitly stating what columns to print, and keeping the same output, the code takes 7.86s.
<table>
<tr>
<th>Full Journal name</th>
<th>Journal name abbr.</th>
</tr>

<% for journalabbr in @journalabbrs %>
<tr>
<td><%=h journalabbr.full_name %></td>
<td><%=h journalabbr.abbr %></td>
<td><%= link_to 'Show', :action => 'show', :id => journalabbr %></td>
<td><%= link_to 'Edit', :action => 'edit', :id => journalabbr %></td>
<td><%= link_to 'Destroy', { :action => 'destroy', :id => journalabbr }, :confirm => 'Are you sure?' %></td>
</tr>
<% end %>
</table>

Removing all erb takes 0.46s.
<table>
<tr>
<th>Full Journal name</th>
<th>Journal name abbr.</th>
</tr>

<% for journalabbr in @journalabbrs %>
<tr>
<td><%=h journalabbr.full_name %></td>
<td><%=h journalabbr.abbr %></td>
</tr>
<% end %>
</table>
Now, removing all link_tos and replacing them with explicit HTML and javascript, with the same functionality as the first code, takes 0.655s! Just as neat and much faster!
<table>
<tr>
<th>Full Journal name</th>
<th>Journal name abbr.</th>
</tr>

<% for journalabbr in @journalabbrs %>
<tr>
<td><%=h journalabbr.full_name %></td>
<td><%=h journalabbr.abbr %></td>
<td><a href='/journalabbr/show/<%= journalabbr.id %>'>Show</a></td>
<td><a href='/journalabbr/edit/<%= journalabbr.id %>'>Edit</a></td>
<td><a href='/journalabbr/destroy/<%= journalabbr.id %>' onclick="return confirm('Are you sure?');">Destroy</a></td>
</tr>
<% end %>
</table>
Cool code HTML escaping and highlighting from palfrader.org

Comments

Post a Comment

Popular posts from this blog

A note on Python's __exit__() and errors

Python's context managers are a very neat way of handling code that needs a teardown once you are done. Python objects have do have a destructor method ( __del__ ) called right before the last instance of the object is about to be destroyed. You can do a teardown there. However there is a lot of fine print to the __del__ method. A cleaner way of doing tear-downs is through Python's context manager , manifested as the with keyword. class CrushMe: def __init__(self): self.f = open('test.txt', 'w') def foo(self, a, b): self.f.write(str(a - b)) def __enter__(self): return self def __exit__(self, exc_type, exc_val, exc_tb): self.f.close() return True with CrushMe() as c: c.foo(2, 3) One thing that is important, and that got me just now, is error handling. I made the mistake of ignoring all those 'junk' arguments ( exc_type, exc_val, exc_tb ). I just skimmed the docs and what popped out is that you need to return True or

Using adminer on Mac OS X

adminer is a nice php based sqlite manager. I prefer the firefox plugin "sqlite manager" but it currently has a strange issue with FF5 that basically makes it unworkable, so I was looking for an alternative to tide me over. I really don't want apache running all the time on my computer and don't want people browsing to my computer, so what I needed to do was: Download the adminer php script into /Library/WebServer/Documents/ Change /etc/apache2/httpd.conf to allow running of php scripts (uncomment the line that begins: LoadModule php5_module Start the apache server: sudo apachectl -k start Operate the script by going to localhost Stop the server: sudo apachectl -k stop